Skip to content

STOR-2627: Add MutableCSINodeAllocatableCount to Dev- and TechPreview #2502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2025
Merged

STOR-2627: Add MutableCSINodeAllocatableCount to Dev- and TechPreview #2502

merged 1 commit into from
Oct 21, 2025

Conversation

@jsafrane
Copy link
Contributor

@jsafrane jsafrane commented Sep 25, 2025

MutableCSINodeAllocatableCount is beta + disabled by default in Kubernetes 1.34 (alpha in 1.33). We want it tested in TP clusters, both by CI and 4.21 customers.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 25, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 25, 2025 •
edited by openshift-ci bot
Loading

@jsafrane: This pull request references STOR-2627 which is a valid jira issue.

In response to this:

MutableCSINodeAllocatableCount is beta + disabled by default in Kubernetes 1.34 (alpha in 1.33). We want it tested in TP clusters, both by CI and 4.21 customers.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 25, 2025

Hello @jsafrane! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 25, 2025
@jsafrane jsafrane mentioned this pull request Sep 25, 2025
Open
JoelSpeed
JoelSpeed reviewed Sep 25, 2025
View reviewed changes
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 25, 2025

/test remaining-required

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2025
@everettraven
Copy link
Contributor

everettraven commented Oct 2, 2025

/retest

1 similar comment
@jsafrane
Copy link
Contributor Author

jsafrane commented Oct 6, 2025

/retest

@JoelSpeed
Copy link
Contributor

JoelSpeed commented Oct 6, 2025

@jsafrane over to you for the verified label

@Phaow
Copy link

Phaow commented Oct 20, 2025

/verified by CI
In e2e-aws-ovn-techpreview, I could see MutableCSINodeAllocatableCount enabled as expected.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 20, 2025
@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 20, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 20, 2025

@Phaow: This PR has been marked as verified by CI.

In response to this:

/verified by CI
In e2e-aws-ovn-techpreview, I could see MutableCSINodeAllocatableCount enabled as expected.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Phaow
Copy link

Phaow commented Oct 20, 2025

Hi @jsafrane , needs a rebase ^^

@jsafrane
Add MutableCSINodeAllocatableCount to Dev- and TechPreview
d96bf86 
MutableCSINodeAllocatableCount is beta + disabled by default in Kubernetes
1.34 (alpha in 1.33). We want it tested in TP clusters, both by CI and
customers.
@jsafrane jsafrane force-pushed the MutableCSINodeAllocatableCount-tp branch from 5c12ab4 to d96bf86 Compare October 21, 2025 09:33
@openshift-ci-robot openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Oct 21, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 21, 2025
@JoelSpeed
Copy link
Contributor

JoelSpeed commented Oct 21, 2025

/lgtm
/verified by E2E

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 21, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 21, 2025

@JoelSpeed: This PR has been marked as verified by E2E.

In response to this:

/lgtm
/verified by E2E

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 21, 2025

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jsafrane
Copy link
Contributor Author

jsafrane commented Oct 21, 2025

Rebased. I am curious what will happen now that we have 1.34 in OCP...

@jsafrane
Copy link
Contributor Author

jsafrane commented Oct 21, 2025

they succeeded in the TP job

  • [sig-storage] MutableCSINodeAllocatableCount [FeatureGate:MutableCSINodeAllocatableCount] [Beta] [Feature:OffByDefault] Attach Limit Exceeded should transition pod to failed state when attachment limit exceeded [Suite:openshift/conformance/parallel] [Suite:k8s]
  • [sig-storage] MutableCSINodeAllocatableCount [FeatureGate:MutableCSINodeAllocatableCount] [Beta] [Feature:OffByDefault] Dynamic Allocatable Count should observe dynamic changes in CSINode allocatable count [Suite:openshift/conformance/parallel] [Suite:k8s]

@jsafrane
Copy link
Contributor Author

jsafrane commented Oct 21, 2025

the only thing that failed are metrics:

: [Monitor:metrics-api-availability][sig-instrumentation] disruption/metrics-api connection/new should be available throughout the test expand_more 0s
: [Monitor:metrics-api-availability][sig-instrumentation] disruption/metrics-api connection/reused should be available throughout the test expand_more

It looks like a flake...
/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 21, 2025

@jsafrane: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn d96bf86 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 8c9acca into openshift:master Oct 21, 2025
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@everettraven everettraven Awaiting requested review from everettraven

1 more reviewer

@JoelSpeed JoelSpeed JoelSpeed left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@JoelSpeed JoelSpeed

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jsafrane @openshift-ci-robot @everettraven @JoelSpeed @Phaow @openshift-merge-robot